refactor bookingRequest into service and improve error handling + front-end refactor #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SjoenH
force-pushed
the
chore/refactor_bookingRequestsService
branch
from
fadf9f3 to
47832e2
Compare
SjoenH
force-pushed
the
chore/refactor_bookingRequestsService
branch
from
7f7079a to
637698d
Compare
SjoenH
force-pushed
the
chore/refactor_bookingRequestsService
branch
from
2b9ac47 to
3de42ed
Compare
SjoenH
changed the title
SjoenH
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, an overhaul of the front-end booking request code. I started by trying to simplify components here but ended quite similar to what we had before... 🙈 I hope you don't mind @wigsnes ❤️
I just wanted to mention that the save button has been removed.
Instead, clicking a period in the calendar books it right away. And it can be toggled back and forth as much as you want. Relying on the state in the back-end instead of local.
A loading state has been added to the button as well when toggling its state.